[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

2019-07-31 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL367455: Fix completion for functions in anonymous namespaces (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

2019-07-31 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D65498#1607819 , @teemperor wrote: > I think it's possible to rewrite the line when doing a completion, but I > remember that I got annoyed when I tried understand the code responsible for > that (and decipher the magic r

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

2019-07-31 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. I think it's possible to rewrite the line when doing a completion, but I remember that I got annoyed when I tried understand the code responsible for that (and decipher the magic return values). Can you file a radar maybe and I'll fix this once I got around to refacto

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

2019-07-31 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D65498#1607805 , @labath wrote: > I don't immediately see a better way to fix this, but I'm not terribly > familiar with this machinery either. I guess one day we may want to extend > the completion machinery to be able t

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

2019-07-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I don't immediately see a better way to fix this, but I'm not terribly familiar with this machinery either. I guess one day we may want to extend the completion machinery to be able to expand "foo" into "(anonymous namespace)::foobar", but that's likely to be a larger un

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

2019-07-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, jingham. JDevlieghere added a project: LLDB. Herald added subscribers: abidh, aprantl. I was going through some of the old bugs and came across PR21069 which I was able to reproduce. The issue is that we match th