[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

labath added a comment. In D65489#1609001 , @JDevlieghere wrote: > In D65489#1608936 , @labath wrote: > > > Yeah, the C arrays aren't the prettiest sight, but OTOH your tablegen files > > don't respect the column

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

JDevlieghere added a comment. In D65489#1608936 , @labath wrote: > In D65489#1608904 , @JDevlieghere > wrote: > > > I don't have any cleanups planned for now. My motivation is purely > > aesthetical: I don't like

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

labath added a comment. In D65489#1608904 , @JDevlieghere wrote: > I don't have any cleanups planned for now. My motivation is purely > aesthetical: I don't like the `// clang-format off` markers and think the C > arrays look messy with the multiline od

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

JDevlieghere added a comment. In D65489#1607833 , @labath wrote: > In D65489#1607807 , @JDevlieghere > wrote: > > > In D65489#1607801 , @labath wrote: > > > > > Why do we ne

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

labath added a comment. In D65489#1607807 , @JDevlieghere wrote: > In D65489#1607801 , @labath wrote: > > > Why do we need a separate backend for this? Couldn't this be emitted as a > > part of the same `#include

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

JDevlieghere added a comment. In D65489#1607801 , @labath wrote: > Why do we need a separate backend for this? Couldn't this be emitted as a > part of the same `#include "XXXProperties.inc"` which defines the property > definition? The two logically belo

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

labath added a comment. Why do we need a separate backend for this? Couldn't this be emitted as a part of the same `#include "XXXProperties.inc"` which defines the property definition? The two logically belong together, and the only reason they were separate variables in the first place was the

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

JDevlieghere updated this revision to Diff 212485. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65489/new/ https://reviews.llvm.org/D65489 Files: lldb/include/lldb/Core/OptionEnumValueElementsBase.td lldb/source/Core/CMakeLists.txt lldb/sourc

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

JDevlieghere created this revision. JDevlieghere added a reviewer: teemperor. JDevlieghere added a project: LLDB. Herald added a subscriber: mgorny. Option enum value elements are used by both properties and options. They're another good canidate for tablegen'ing. Repository: rLLDB LLDB http