[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

This revision was automatically updated to reflect the committed changes. Closed by commit rL367664: SymbolVendor: Introduce Module::GetSymbolFile (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

labath updated this revision to Diff 212764. labath added a comment. - add two null checks - replace GetSymbolVendor with GetSymbolFile in a couple of more places, where it is easy to do CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65435/new/ https://reviews.llvm.org/D65435 Files:

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

labath added a comment. In D65435#1608276 , @clayborg wrote: > Alternatively we can switch to using a reference for: > > SymbolFile &Module::GetSymbolFile(bool can_create Stream *feedback_strm); > > > As I believe we always fall back to SymbolFileSymtab

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

clayborg added a comment. Alternatively we can switch to using a reference for: SymbolFile &Module::GetSymbolFile(bool can_create Stream *feedback_strm); As I believe we always fall back to SymbolFileSymtab don't we? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65435/new/ https://r

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just add a few null checks and this will be good to go. Comment at: source/Commands/CommandObjectTarget.cpp:2240 Module *m = target->GetImages().GetMod

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

labath created this revision. labath added reviewers: JDevlieghere, clayborg, jingham. This is the next step in avoiding funneling all SymbolFile calls through the SymbolVendor. Right now, it is just a convenience function, but it allows us to update all calls to SymbolVendor functions to access t