[Lldb-commits] [PATCH] D65329: SymbolVendor: Move locking into the Symbol Files

This revision was automatically updated to reflect the committed changes. Closed by commit rL367298: SymbolVendor: Move locking into the Symbol Files (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LA

[Lldb-commits] [PATCH] D65329: SymbolVendor: Move locking into the Symbol Files

labath added a comment. In D65329#1604847 , @clayborg wrote: > We will need to watch future submissions closely as this increases the chance > that someone will extend a SymbolFile by overriding a virtual function and > forget to lock. I've though abou

[Lldb-commits] [PATCH] D65329: SymbolVendor: Move locking into the Symbol Files

clayborg added a comment. We will need to watch future submissions closely as this increases the chance that someone will extend a SymbolFile by overriding a virtual function and forget to lock. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65329/new/ https://reviews.llvm.org/D65329

[Lldb-commits] [PATCH] D65329: SymbolVendor: Move locking into the Symbol Files

labath created this revision. labath added reviewers: clayborg, JDevlieghere, jingham. Herald added a subscriber: aprantl. Herald added a reviewer: jdoerfert. The last bit of functionality in SymbolVendor passthrough functions is the locking the module mutex. While it may be nice doing the locking