[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 1min

2019-07-29 Thread Jan Kratochvil via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rL367234: [lldb] Increase testsuite packet-timeout 5secs -> 1min (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subsc

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 1min

2019-07-29 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/tools/lldb-test/lldb-test.cpp:979 ModuleList::GetGlobalModuleListProperties().SetEnableExternalLookup(false); + // There is no SB API for settings in general like: + // GetG

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 1min

2019-07-29 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM, thanks. BTW, I was pretty much a python noob too when starting with lldb, but our test suite has forced me to become somewhat of an expert. :) Comment at: lldb/tools/

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 1min

2019-07-26 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In D65271#1602143 , @labath wrote: > I think I'd go for threading it in from VSCodeTestCaseBase. Maybe not as an > argument to `request_attach` and friends, but possibly as an argument to the > `DebugCommunication` object c