[Lldb-commits] [PATCH] D65207: LLGS: fix tracking execve on linux

2019-07-24 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366985: LLGS: fix tracking execve on linux (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D65207: LLGS: fix tracking execve on linux

2019-07-24 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D65207#1600100 , @clayborg wrote: > Is this not going to be racy on other platforms? Or do all platforms stop at > entry point once a program has been exec'ed? I am worried we might miss the > breakpoint. stopping on exec is

[Lldb-commits] [PATCH] D65207: LLGS: fix tracking execve on linux

2019-07-24 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. LGTM. I don't think the use of the posix_spawn API are important for the test case to exercise. If posix_spawn had a problem on darwin systems, lldb/debugserver's process launching would turn it up pretty quick. CHANGES SINCE

[Lldb-commits] [PATCH] D65207: LLGS: fix tracking execve on linux

2019-07-24 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Is this not going to be racy on other platforms? Or do all platforms stop at entry point once a program has been exec'ed? I am worried we might miss the breakpoint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65207/new/ https://reviews.llvm.org/D65207 __

[Lldb-commits] [PATCH] D65207: LLGS: fix tracking execve on linux

2019-07-24 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, jasonmolenda. Due to a logic error, lldb-server ended up asserting/crashing every time the debugged process attempted an execve(). This fixes the error, and extends TestExec to work on other platforms too. The "extension" consists of