[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

sammccall added subscribers: chandlerc, sammccall. sammccall added inline comments. Comment at: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:77 +#define LLDB_PROPERTIES_dynamicloaderdarwinkernel +#include "Properties.inc" +}; --

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rL367058: Let tablegen generate property definitions (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

friss added a comment. When we hit that merge conflict issue 2 days ago (which mismatched a property and its enum), the first thing that came to my mind was that a tablegen approach would have prevented it. For some reason it seemed more natural to me, and it still does. I might have liked a .

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I think this is fine. Using `.def` files would be okay too, but I like the sanity checks that Jonas introduced in the LLDBPropertyDefEmitter CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

JDevlieghere updated this revision to Diff 211800. JDevlieghere added a comment. Add sanity check that I mentioned. This actually caught a few properties that didn't have defaults. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65185/new/ https://reviews.llvm.org/D65185 Files: lldb/C

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

labath added a comment. In D65185#1599423 , @JDevlieghere wrote: > In D65185#1599262 , @labath wrote: > > > .def files can omit fields too: `#define BOOL_PROPERTY(name, global, > > default, desc) PROPERTY(name, Op

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

JDevlieghere added a comment. In D65185#1599262 , @labath wrote: > .def files can omit fields too: `#define BOOL_PROPERTY(name, global, default, > desc) PROPERTY(name, OptionValue::eTypeBoolean, global, default, nullptr, {}, > desc)`. Some sanity checkin

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

JDevlieghere updated this revision to Diff 211528. JDevlieghere added a comment. Have separate tablegen files for plugins. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65185/new/ https://reviews.llvm.org/D65185 Files: lldb/CMakeLists.txt lldb/include/lldb/Core/CMakeLists.txt lld

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

labath added a comment. In D65185#1599215 , @JDevlieghere wrote: > In D65185#1598586 , @labath wrote: > > > My dream is to one day be able to define a property by simply declaring a > > variable somewhere (say: `P

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

JDevlieghere added a comment. In D65185#1598586 , @labath wrote: > My dream is to one day be able to define a property by simply declaring a > variable somewhere (say: `Property Foo(ParentProperty, "foo", "description > of foo", DefaultValue);`), and tha

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

labath added a subscriber: aprantl. labath added a comment. My dream is to one day be able to define a property by simply declaring a variable somewhere (say: `Property Foo(ParentProperty, "foo", "description of foo", DefaultValue);`), and that one could just get/set them via something like `co

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, friss, xiaobai, labath, clayborg. Herald added a subscriber: mgorny. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. Property definitions are currently defined in a `PropertyDefinition` array and have a