This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL367418: Fix issues with inferior stdout coming out of order
(authored by labath, committed by ).
Herald added a project: L
labath updated this revision to Diff 211439.
labath added a comment.
Thanks for the feedback. Updating the patch to avoid calling the flush function
twice.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65152/new/
https://reviews.llvm.org/D65152
Files:
include/lldb/Core/Debugger.h
jingham added a comment.
I agree with Greg, having one function that can do any of the combinations of
stdout & stderr seems more convenient.
Other than that, this is fine.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65152/new/
https://reviews.llvm.org/D65152
clayborg added inline comments.
Comment at: include/lldb/Core/Debugger.h:350
+ std::mutex m_output_flush_mutex;
+ void FlushProcessOutput(Process &process, bool is_stdout);
What about making this function:
```
void Debugger::FlushProcessOutput(Process &proce
labath updated this revision to Diff 211328.
labath added a comment.
Remove sleep, left over from testing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65152/new/
https://reviews.llvm.org/D65152
Files:
include/lldb/Core/Debugger.h
include/lldb/Interpreter/CommandInterpreter.h
so
labath created this revision.
labath added reviewers: clayborg, jingham.
Herald added a subscriber: jfb.
We've had a bug where two pieces of code, executing on two threads were
attempting to write inferior output simultaneously. The first one was in
Debugger::HandleProcessEvent, which handled the
