[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-24 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. In D65109#1598695 , @sgraenitz wrote: > > We discussed this and came to an agreement only a few hours before in the > > team meeting > > After all, LLVM is open-source and has a community. Making preemptive > decisions in interna

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-24 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added a comment. > We discussed this and came to an agreement only a few hours before in the > team meeting After all, LLVM is open-source and has a community. Making preemptive decisions in internal team meetings sounds concerning. > As far as we know, Greg was the only user of the

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-23 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D65109#1597492 , @sgraenitz wrote: > Seriously, discussion for changes like this should be open for more than > 1h15min! I am in favor of the change in principle, but there's a number of > things that have been rushed ove

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-23 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D65109#1597492 , @sgraenitz wrote: > Seriously, discussion for changes like this should be open for more than > 1h15min! We discussed this and came to an agreement only a few hours before in the team meeting, which you

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-23 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added a comment. [lldb] Remove Xcode project legacy: https://reviews.llvm.org/D65155 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65109/new/ https://reviews.llvm.org/D65109 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-23 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added a comment. Herald added a subscriber: ormris. Seriously, discussion for changes like this should be open for more than 1h15min! I am in favor of the change in principle, but there's a number of things that have been rushed over here, e.g.: cmake/XcodeHeaderGenerator/CMakeLists

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366739: [LLDB] Remove the Xcode project (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Let's move the discussion about the script to D65114 . Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65109/new/ https://reviews.llvm.org/D65109 ___ ll

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-22 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. scripts/sort-pbxproj.rb can go too. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65109/new/ https://reviews.llvm.org/D65109 _

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-22 Thread Nathan Lanza via Phabricator via lldb-commits
lanza added inline comments. Comment at: lldb/utils/xcode.py:1 +#!/usr/bin/env python + This could probably be just a 10 line `make` file that you just `make -f lldb/utils/xcode.mk`. Not sure if you guys are a fan of this method, but we tend to find it to be mu

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D65109#1596294 , @clayborg wrote: > I am fine with removing the Xcode project. Others should ok it too. > > > I've included a new script to streamline the process: it creates two build > > directories in the current direct

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-22 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. I am fine with removing the Xcode project. Others should ok it too. > I've included a new script to streamline the process: it creates two build > directories in the current directory. The first directory is for LLVM and > Clang which uses Ninja to build. The second di

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

2019-07-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: jingham, jasonmolenda, clayborg, sgraenitz. JDevlieghere added a project: LLDB. Herald added subscribers: teemperor, jfb, srhines. Finally, after a lot of hard work from a bunch of people, we're in a state where we can unify LLDB's