[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

This revision was automatically updated to reflect the committed changes. Closed by commit rL367480: [API] Remove use of ClangASTContext from SBTarget (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64964/new/ https://reviews.llvm.org/D64964 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai updated this revision to Diff 212483. xiaobai added a comment. Removed argument to GetScratchTypeSystems from SBTarget CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64964/new/ https://reviews.llvm.org/D64964 Files: include/lldb/Target/Target.h source/API/SBTarget.cpp sour

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai updated this revision to Diff 212482. xiaobai added a comment. Update GetScatchTypeSystems to account for changes to TypeSystem usage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64964/new/ https://reviews.llvm.org/D64964 Files: include/lldb/Target/Target.h source/API/SBTa

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai added a comment. In D64964#1592851 , @JDevlieghere wrote: > All uses of this new function drop the error on the ground. Does that mean it > doesn't matter? If it does, should we return an expected instead? Should we > stop on the first error, or

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. All uses of this new function drop the error on the ground. Does that mean it doesn't matter? If it does, should we return an expected instead? Should we stop on the firs

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. Makes it really clear that we need SBTarget::FindFirstTypeForLanguage, etc. But FindFirstType was always a crapshoot anyway... CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, jingham, clayborg, compnerd. The methods to find types in a Target aren't clang specific and are pretty generalizable to type systems. Additionally, to support some of the use cases in SBTarget, I've added a "GetScratchTypeSyste