[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

shafik added a comment. Thanks for fixing this one! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64917/new/ https://reviews.llvm.org/D64917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe21fc8770ca4: Add offsetof support to expression evaluator. (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64917/new/ https://review

[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This is good for now. I would add a comment explaining what you explained in the differential at the beginning of the macro section. Great work! Repository: rLLDB LLDB CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

clayborg added a comment. nice! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64917/new/ https://reviews.llvm.org/D64917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

teemperor created this revision. teemperor added reviewers: shafik, davide. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We currently don't support offsetof in the expression evaluator as it is implemented as a macro (which then calls __builtin_offsetof) in stddef.h. The