[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

2019-07-11 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365813: [lldb] Make TestDeletedExecutable more reliable (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

2019-07-11 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor updated this revision to Diff 209231. teemperor edited the summary of this revision. teemperor added a comment. - Timeout -> file synchronization. - Made the test process run longer just in case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64546/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

2019-07-11 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D64546#1580618 , @friss wrote: > This might mitigate the issue, but timeouts like this are bound to fail in > some circumstances (machine load, ...). It's more work, but can we instead > have the inferior produce an observable

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

2019-07-11 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. Yeah, I'd rather have an explicit communication between debugger and debuggee. We tried to put sleeps in the code [for e.g. `lldb-mi` tests in the past] and they end up failing anyway sporadically, which makes a pain to track the problem down. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

2019-07-11 Thread Frederic Riss via Phabricator via lldb-commits
friss added a comment. This might mitigate the issue, but timeouts like this are bound to fail in some circumstances (machine load, ...). It's more work, but can we instead have the inferior produce an observable side effect (eg, print some output) and synchronize on this? Repository: rLLDB

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

2019-07-10 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: davide. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It seems that calling Popen can return to the caller before the started process has read all the needed information from its executable. This means that in c