[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

2019-07-10 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365617: [CMake] `install-distribution` for LLDB on Darwin (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

2019-07-09 Thread Alex Langford via Phabricator via lldb-commits
xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I like the idea a lot and the implementation looks alright. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64408/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

2019-07-09 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I'm not very familiar with the details here, but this approach seems reasonable to me... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64408/new/ https://reviews.llvm.org/D64408 __

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

2019-07-09 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added a comment. Usage example that should work in conjunction with D64397 and D64399 : $ cd path/to/lldb-deps-relwithdebinfo $ cmake -GNinja -C/path/to/llvm-project/lldb/cmake/caches/Apple-lldb-base.cmake \

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

2019-07-09 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. sgraenitz added reviewers: xiaobai, compnerd, JDevlieghere, davide, labath, mgorny. Herald added a project: LLDB. There's a number of requirements for installing LLDB on macOS that are untypical for LLVM projects: use special install-prefix for LLDB.framework, s