[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

2019-07-10 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365615: [CMake] Remove extra lldb-framework target (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

2019-07-09 Thread Alex Langford via Phabricator via lldb-commits
xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64397/new/ https://reviews.llvm.org/D64397 _

[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

2019-07-09 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added a comment. This simplifies my proposal in D64399 , because I don't need it in `LLVM_DISTRIBUTION_COMPONENTS` and avoid dummy `install-distribution` and `install-distribution-stripped` targets. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

2019-07-09 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. sgraenitz added a reviewer: xiaobai. Herald added a subscriber: mgorny. Herald added a project: LLDB. The custom lldb-framework target was meant to encapsulate all build steps that LLDB.framework needs on top of the ordinaly liblldb. In the end all of it happens