[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

2019-07-10 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. never mind, I missed that you had! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64373/new/ https://reviews.llvm.org/D64373 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

2019-07-10 Thread Christian Biesinger via Phabricator via lldb-commits
cbiesinger added a comment. Yeah. (I thought I did? I'm not super familiar with this interface) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64373/new/ https://reviews.llvm.org/D64373 ___ lldb-commits

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

2019-07-10 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. ok, so do you want to abandon this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64373/new/ https://reviews.llvm.org/D64373 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

2019-07-09 Thread Christian Biesinger via Phabricator via lldb-commits
cbiesinger added a comment. Ah, this works because Swig (?) adds compatibility macros to LLDBWrapPython: #define PyInt_Check(x) PyLong_Check(x) #define PyInt_AsLong(x) PyLong_AsLong(x) #define PyInt_FromLong(x) PyLong_FromLong(x) #define PyInt_FromSize_t(x) PyLong_FromSize_t(x) (etc) Repository:

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

2019-07-08 Thread Christian Biesinger via Phabricator via lldb-commits
cbiesinger abandoned this revision. cbiesinger added a comment. It seems this wasn't necessary, I had just misconfigured my build. (I don't understand how this works though...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64373/new/ https://revie

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

2019-07-08 Thread Christian Biesinger via Phabricator via lldb-commits
cbiesinger created this revision. cbiesinger added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In Python 3, PyInt doesn't exist (all integers are PyLongs). This patch makes LLVM not use PyInt when compiling for Python 3. (Some code already had such