[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

labath added inline comments. Comment at: lldb/docs/resources/build.rst:17 +* `Clang `_ + +The following requirements are shared on all platforms. Should we also mention lld somewhere? Lld is a hard requirement for running

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

JDevlieghere closed this revision. JDevlieghere added a comment. Landed in rL365081 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64154/new/ https://reviews.llvm.org/D64154 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

JDevlieghere updated this revision to Diff 207880. JDevlieghere added a comment. Make Windows invocation look like a Windows invocation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64154/new/ https://reviews.llvm.org/D64154 Files: lldb/docs/resources/build.rst Index: lldb/docs/reso

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

JDevlieghere updated this revision to Diff 207879. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Move up custom test compilers - Specify that the CMake options are not Windows specific CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64154/new/ https://revi

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

xiaobai added a comment. Thanks for doing this! :D Comment at: lldb/docs/resources/build.rst:145 - cmake -G Ninja -DLLDB_TEST_DEBUG_TEST_CRASHES=1 -DPYTHON_HOME=C:\Python35 -DLLDB_TEST_USE_CUSTOM_C_COMPILER=ON -DLLDB_TEST_C_COMPILER=d:\src\llvmbuild\ninja_release\bin\clang

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:132 environment variable if it is specified). * ``LLDB_TEST_C_COMPILER`` or ``LLDB_TEST_CXX_COMPILER``: The test suite needs to be able to find a copy of clang.exe that it can use to compile

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mgorny, stella.stamenova, teemperor, sgraenitz. JDevlieghere added a project: LLDB. Herald added a subscriber: srhines. The current build instructions are structured according the host platform. Instead of having instructi