[Lldb-commits] [PATCH] D63770: Options: Reduce code duplication

2019-07-10 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365665: Options: Reduce code duplication (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D63770: Options: Reduce code duplication

2019-07-07 Thread Michał Górny via Phabricator via lldb-commits
mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63770/new/ https://reviews.llvm.org/D63770 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D63770: Options: Reduce code duplication

2019-06-25 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: mgorny, aprantl. While investigating breakages caused by D63110 , I noticed we were building the short options strings in three places. Some of them used a leading ':' to detect missing arguments, and some didn