hintonda added a comment.
I just reviewed all the release notes, and while 3.9 relaxed the usage of
TARGET_OBJECTS, cmake doesn't explicitly mention allowing them in
`target_link_libraries` until release 3.15.
I don't have any of those versions, but it looks like 3.15 is probably the
version y
hintonda accepted this revision.
hintonda added a comment.
This revision is now accepted and ready to land.
Otherwise, LGTM, thanks!
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63544/new/
https://reviews.llvm.org/D63544
hintonda added inline comments.
Comment at: tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt:16
+else()
+ target_sources(LLDBMiUtilTests PRIVATE $)
+endif()
I'm assuming from your comment, that this is a performance issue. If so, could
you add a comment
tatyana-krasnukha added a comment.
It will cause some time overhead for linking a library. Linking is already
formidable for the project and I'd avoid it when possible.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63544/new/
https://reviews.llvm.org/D63544
labath added a comment.
why not just change `lldb-mi-utils` into a conventional (STATIC) library, at
which point it can just be linked in using regular `target_link_libraries`,
which has worked since forever?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63544
tatyana-krasnukha created this revision.
tatyana-krasnukha added a reviewer: hintonda.
tatyana-krasnukha added a project: LLDB.
Herald added subscribers: lldb-commits, mgorny, ki.stfu.
Using $ in anything other than add_library and
add_executable was not supported until cmake 3.9.
The issue was a
