[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

This revision was automatically updated to reflect the committed changes. Closed by commit rL364009: DWARF: Add "dwo_num" field to the DIERef class (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.h:35 +assert(this->dwo_num() == dwo_num && "Dwo number out of range?"); + } Sounds good C

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

labath updated this revision to Diff 205760. labath marked an inline comment as done. labath added a comment. - use uint32_t for bitfields - pass DIERefs by value - implement GetUID so that it is structurally similar to the decoding code in DecodeUID CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

labath marked 8 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.h:30 - DIERef(Section s, llvm::Optional u, dw_offset_t d) - : m_section(s), m_unit_offset(u.getValueOr(DW_INVALID_OFFSET)), -m_die_offset(d) {

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.h:30 - DIERef(Section s, llvm::Optional u, dw_offset_t d) - : m_section(s), m_unit_offset(u.getVa

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

labath updated this revision to Diff 205527. labath added a comment. Remove the cu_offset field from DIERef, bringing the total size back down to "8", as dicussed here, and on D63491 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63428/new/ https://rev

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

labath marked 7 inline comments as done. labath added a comment. I've been thinking about the DIERef class a lot while doing this, and the more I thought about it, the more I became convinced that forcing everything to go through DIERefs is not a good idea. It is kind of useful to have it as a s

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

labath updated this revision to Diff 205319. labath marked 2 inline comments as done. labath added a comment. - use the existing function for DWARFDIE->DIERef conversion - fix a bug where we were ignoring the dwo_num and section fields when searching for all entries in a given unit. Technically,

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

clayborg added a comment. I am concerned with increasing the size of DIERef objects. If we go to 12 bytes per DIERef, and we mostly store these in NameToDIE in "lldb_private::UniqueCStringMap m_map;" maps, which contain a std::vector of UniqueCStringMap::Entry objects which are: struct Entry

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added subscribers: arphaman, dexonsmith, mehdi_amini. When dwo support was introduced, it used a trick where debug info entries were referenced by the offset of the compile unit in the main file, but the