This revision was automatically updated to reflect the committed changes.
Closed by commit rL363910: DWARF: Provide accessors to DIERef fields (authored
by labath, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTI
clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.h:48
+ unsigned m_section : 1;
+ dw_offset_t m_unit_offset;
+ dw_offset_t m_die_offset;
Never m
clayborg added a comment.
Just questioning if we want to increase the size of the DIERef struct.
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.h:47-48
+private:
+ unsigned m_section : 1;
+ dw_offset_t m_unit_offset;
+ dw_offset_t m_die_offset;
We we wan
labath updated this revision to Diff 205006.
labath added a comment.
- s/DW_INVALID_OFFSET/llvm::None/ in HashedNameToDIE.h
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63400/new/
https://reviews.llvm.org/D63400
Files:
source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp
source/Plu
labath created this revision.
labath added reviewers: JDevlieghere, aprantl, clayborg.
Herald added a subscriber: arphaman.
labath added a parent revision: D63399: DWARF: Make DIERefs always valid.
labath added a comment.
(also, cu_offset is renamed to unit_offset, as we now support type units too
labath added a comment.
(also, cu_offset is renamed to unit_offset, as we now support type units too)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63400/new/
https://reviews.llvm.org/D63400
___
lldb-commits mailing list
lldb-commits@lists.
