[Lldb-commits] [PATCH] D63399: DWARF: Make DIERefs always valid

This revision was automatically updated to reflect the committed changes. Closed by commit rL363767: DWARF: Make DIERefs always valid (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D63

[Lldb-commits] [PATCH] D63399: DWARF: Make DIERefs always valid

labath marked 2 inline comments as done. labath added a comment. In D63399#1546330 , @clayborg wrote: > I am concerned that our mapping from DIERef to lldb::user_id_t won't work for > all cases now that we are/have expanded the DIERef class (including as

[Lldb-commits] [PATCH] D63399: DWARF: Make DIERefs always valid

clayborg added a comment. I am concerned that our mapping from DIERef to lldb::user_id_t won't work for all cases now that we are/have expanded the DIERef class (including as we add the DWO field). I voiced this concern in https://reviews.llvm.org/D63428. Let me know what you think.

[Lldb-commits] [PATCH] D63399: DWARF: Make DIERefs always valid

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added a subscriber: arphaman. labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:1 //===-- DIERef.cpp

[Lldb-commits] [PATCH] D63399: DWARF: Make DIERefs always valid

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:1 //===-- DIERef.cpp --*- C++ -*-===// // I'm not deleting this file, because I'm going to