[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

This revision was automatically updated to reflect the committed changes. Closed by commit rL363441: Don't try to parse ObjC method if CU isn't ObjC (authored by gclayton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63171/new/ https://reviews.llvm.org/D63171 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

clayborg updated this revision to Diff 204553. clayborg added a comment. Let compiler hoist "cu_language == eLanguageTypeObjC || cu_language == eLanguageTypeObjC_plus_plus" by inlining it into if statement so it is more readable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63171/new/

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

labath added a comment. In D63171#1539187 , @aprantl wrote: > In D63171#1539070 , @clayborg wrote: > > > In D63171#1539049 , @aprantl wrote: > > > > > I suppose one could com

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

aprantl added a comment. In D63171#1539070 , @clayborg wrote: > In D63171#1539049 , @aprantl wrote: > > > I suppose one could compile Objective-C code on Linux using GCC. > > > Will GCC not set the language to ObjC

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

clayborg added a comment. In D63171#1539049 , @aprantl wrote: > I suppose one could compile Objective-C code on Linux using GCC. Will GCC not set the language to ObjC or ObjC++? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63171/new/ https://

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

clayborg marked an inline comment as done. clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:255 + bool is_objc_method = false; + if (check_objc) { +ObjCLanguage::MethodName objc_method(name, true);

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

aprantl added a comment. I suppose one could compile Objective-C code on Linux using GCC. Comment at: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:255 + bool is_objc_method = false; + if (check_objc) { +ObjCLanguage::MethodName objc_method(

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

clayborg created this revision. clayborg added reviewers: labath, aprantl, jingham. Herald added a subscriber: arphaman. Improve manual indexing performance when indexing non objective C code. One question I have is all Darwin compilers currently support the apple DWARF indexes, so do we even ne