[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

aprantl added a comment. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/ https://reviews.llvm.org/D63110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

labath added a comment. BTW, the new version was now failing on linux for a change. I believe r364317 ought to implement this in a way that is compatible with all getopt implementations that we are using... Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/

Re: [Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

I reverted this in r363999 On Thu, Jun 20, 2019 at 2:26 PM Davide Italiano wrote: > > Adrian is OOO. I am looking at this and I'll revert if I can't > understand what's going on. > > On Thu, Jun 20, 2019 at 11:27 AM Stella Stamenova via Phabricator via > lldb-commits wrote: > > > > stella.stamen

Re: [Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

Adrian is OOO. I am looking at this and I'll revert if I can't understand what's going on. On Thu, Jun 20, 2019 at 11:27 AM Stella Stamenova via Phabricator via lldb-commits wrote: > > stella.stamenova added a comment. > > In D63110#1551572 , @mgorny wrote

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

stella.stamenova added a comment. In D63110#1551572 , @mgorny wrote: > @stella.stamenova could you try running the lldb invocation manually like I > did? I'm wondering if you're getting the same issue. It is the same. The interesting thing is that it pa

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

mgorny added a comment. @stella.stamenova could you try running the lldb invocation manually like I did? I'm wondering if you're getting the same issue. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/ https://reviews.llvm.org/D63110 __

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

mgorny added a comment. The added test broke NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/109/steps/run%20unit%20tests/logs/FAIL%3A%20LLDB%3A%3ATestProcessAttach.test Apparently this doesn't work as expected here: $ /home/mgorny/llvm-project/build-rel-master/bin/lldb

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

stella.stamenova added a comment. This test is extremely flaky on Windows - it looks like it passes on the bot less than 10% of the time: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/ https://revi

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363101: Fix a crash in option parsing. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6311

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

clayborg added a comment. nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/ https://reviews.llvm.org/D63110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/ https://reviews.llvm.org/D63110 __

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

aprantl created this revision. aprantl added a reviewer: JDevlieghere. Herald added a project: LLDB. The call to getopt_long didn't handle the case where the *last* option had an argument missing. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63110 Files: lldb/lit/Driver/I