Re: [Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

On 19/06/2019 01:05, Jim Ingham wrote: On Jun 7, 2019, at 2:47 AM, Pavel Labath via Phabricator via lldb-commits wrote: labath planned changes to this revision. labath added a comment. It looks like this problem is more widespread than we originally thought (a bunch of other tests are aff

Re: [Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

> On Jun 7, 2019, at 2:47 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath planned changes to this revision. > labath added a comment. > > It looks like this problem is more widespread than we originally thought (a > bunch of other tests are affected too). I'll need to t

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

labath planned changes to this revision. labath added a comment. It looks like this problem is more widespread than we originally thought (a bunch of other tests are affected too). I'll need to think whether we can come up with a more general solution. In D62948#1533088

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

jgorbe added a comment. About %T not working for "process launch", what about something like `RUN: %lldb -b --one-line-before-file "process launch --stdout %T/x86-zmm-write.out" -s %s %t` and then FileCheck-ing? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62948/new/ https://reviews.

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM, thanks. I also hacked `-m32` for local testing. I generally agree this is a good thing to do but I don't really know how to reliably determine support for this. My main concern were C++

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

labath updated this revision to Diff 203378. labath added a comment. revert the 32-on-64-bit part CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62948/new/ https://reviews.llvm.org/D62948 Files: lit/Register/x86-64-gp-write.test lit/Register/x86-64-write.test lit/Register/x86-64-x

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

labath added a comment. In D62948#1532549 , @mgorny wrote: > In D62948#1532531 , @labath wrote: > > > Update other tests too. I also forgot to mention that this enables the > > 32-bit > > tests to run on 64-bit pl

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

mgorny added a comment. In D62948#1532531 , @labath wrote: > Update other tests too. I also forgot to mention that this enables the 32-bit > tests to run on 64-bit platforms too by explicitly compiling for 32-bit > (-m32). I'm not sure if this is a goo

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

labath updated this revision to Diff 203370. labath added a comment. Update other tests too. I also forgot to mention that this enables the 32-bit tests to run on 64-bit platforms too by explicitly compiling for 32-bit (-m32). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62948/new/ htt

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

mgorny added a comment. I'm sorry but could you also change other write tests (zmm?) to match. Comment at: lit/Register/x86-64-gp-write.test:6 # RUN: %lldb -b -s %s %t | FileCheck %s -process launch +# RUN: FileCheck %s --check-prefix=INF mgorny wrote: > > Any reason not to u

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

labath marked an inline comment as done. labath added inline comments. Comment at: lit/Register/x86-64-gp-write.test:6 # RUN: %lldb -b -s %s %t | FileCheck %s -process launch +# RUN: FileCheck %s --check-prefix=INF Any reason not to use `%T` directly in paths rather than changi

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

mgorny added inline comments. Comment at: lit/Register/x86-64-gp-write.test:6 # RUN: %lldb -b -s %s %t | FileCheck %s -process launch +# RUN: FileCheck %s --check-prefix=INF https://reviews.llvm.org/D62948/new/ https://reviews.llvm.org/D62948

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

labath created this revision. labath added reviewers: mgorny, jgorbe. The linux kernel doesn't guarantee that the data written to a pty will instantly be available for reading on the other side. So what sometimes happens here is that the inferior dumps all register values and exits, lldb registers