[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

hiraditya added a comment. Herald added subscribers: wangpc, jobnoorman, luke. We should close this as it has been pushed upstream as part of https://reviews.llvm.org/rG847de9c332775d1841fec9fea5cb5c41592a4c8f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

tzb99 added a comment. In D62732#3681388 , @jasonmolenda wrote: > In D62732#3680154 , @tzb99 wrote: > >> In D62732#2790160 , @sven wrote: >> >>> > > > >>> But the unwind ca

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jasonmolenda added a comment. In D62732#3680154 , @tzb99 wrote: > In D62732#2790160 , @sven wrote: > >> >> But the unwind can not work on my machine, the issue is similar to which >> @jade reported >> >> (lld

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

tzb99 added a comment. In D62732#2790160 , @sven wrote: > In D62732#2790087 , @luismarques > wrote: > >> In D62732#2790028 , @luismarques >> wrote: >> >>> That's surprising

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#3157524 , @kasper81 wrote: > Hi Luis, are you planning on adding plugin architecture support (in > `lldb/source/Plugins/Architecture`) as part of this work? I commandeered this patch from Simon Cook, the original au

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

kasper81 added a comment. Hi Luis, are you planning on adding plugin architecture support (in `lldb/source/Plugins/Architecture`) as part of this work? Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:1152 + triple.getArch() == llvm::Triple::riscv6

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jrtc27 added a comment. In D62732#2995111 , @MaskRay wrote: > Hi Luís, is this still needed after D86292 ? > Or are there missing pieces? > @felixonmars reported that https://archriscv.felixc.at/.status/logs/lldb.log > st

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

MaskRay added a subscriber: felixonmars. MaskRay added a comment. Hi Luis, is this still needed after D86292 ? Or are there missing pieces? @felixonmars reported that https://archriscv.felixc.at/.status/logs/lldb.log still failed to build on riscv64 Arch Linux. I

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jrtc27 added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:118 + + // Previous frames pc is in ra + row->SetRegisterLocationToRegister(pc_reg_num, ra_reg_num, true); Comment at: lldb/source/Plugins/ABI/RISCV/AB

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

kasper81 added a comment. > I think the main blocker for merging was testing. If it helps, I now have the > RISC-V server in my hands and I should be able to set up a buildbot soon. It certainly will help. Thank you! :) On July 27, 13.x will be branched out. If we can squeeze it in that would b

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2875107 , @kasper81 wrote: > Hi, I have my fingers crossed since this request was opened in 2019. It seems > like it compiles and usable to certain degree. Can this patch be merged and > included in llvm 13 as initi

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

kasper81 added a comment. Hi, I have my fingers crossed since this request was opened in 2019. It seems like it compiles and usable to certain degree. Can this patch be merged and included in llvm 13 as initial riscv64 support? We can then improve it subsequently if bugs show up. Otherwise it w

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

sven added a comment. In D62732#2790087 , @luismarques wrote: > In D62732#2790028 , @luismarques > wrote: > >> That's surprising. I'll see if I can figure out what the issue might be. >> Thanks. > > Confirmed. Som

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2790028 , @luismarques wrote: > That's surprising. I'll see if I can figure out what the issue might be. > Thanks. Confirmed. Something must have broken since the last patch revision. I'll see if I can figure out /

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2789409 , @sven wrote: > I have tried the patch with llvm12, test case is provide by > jade(https://gist.github.com/e2efac2f780ed820277dbaf608805f4e), but it didn't > worked for me. > It seems that the unwind didn't

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

sven added a comment. @luismarques I have tried the patch with llvm12, test case is provide by jade(https://gist.github.com/e2efac2f780ed820277dbaf608805f4e), but it didn't worked for me. After execute 'gdb-remote 1234', the terminal shows: Process 1 stopped * Thread #1, stop reason = sign

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jade added a comment. In D62732#2789409 , @sven wrote: > It seems that the unwind didn't succeed, can you figure out the problem? > my qemu vesion: 4.2.1 > Thanks. Unfortunately, from my last adventures through the lldb codebase in debugging that (see bu

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques updated this revision to Diff 341471. luismarques added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/s

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

aprantl added inline comments. Comment at: lldb/include/lldb/Utility/ArchSpec.h:101 + // RISCV specific flags + enum RISCVflags { In modern LLDB style we would format this as: ``` /// RISCV specific flags. enum class RISCVflags { arch_c = 0x0001, ///<

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

JDevlieghere added a comment. In D62732#2724078 , @luismarques wrote: > In D62732#2724040 , @JDevlieghere > wrote: > >> Any update on the testing strategy yet? It seems like that this is actively >> being used and

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2724040 , @JDevlieghere wrote: > Any update on the testing strategy yet? It seems like that this is actively > being used and worked on, so I'm generally supportive of landing this with > some elementary coverage.

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

JDevlieghere added a comment. Any update on the testing strategy yet? It seems like that this is actively being used and worked on, so I'm generally supportive of landing this with some elementary coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques updated this revision to Diff 341153. luismarques added a comment. Rebase and fix the unwinding issue reported by @jade. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 Files: lldb/include/lld

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jade added a comment. In D62732#2707945 , @jade wrote: > In D62732#2306055 , @labath wrote: > >> ABI plugins are one of the hardest things to test in lldb, particularly >> without actual hardware. That's why we've

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2707945 , @jade wrote: > These files are also available as a gist, which can be grabbed with: `git > clone https://gist.github.com/e2efac2f780ed820277dbaf608805f4e > lldb-riscv-repro` Thank you for the reproducer.

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jade added a comment. In D62732#2306055 , @labath wrote: > ABI plugins are one of the hardest things to test in lldb, particularly > without actual hardware. That's why we've let them be added in the past > without any accompanying tests. The situation i

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2306055 , @labath wrote: > I'm not sure what's the state of risc-v hardware these days and how much > resources do you have available, but if it's at all possible, I'd definitely > recommend adding the lldb-server b

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques updated this revision to Diff 302182. luismarques added a comment. Herald added subscribers: frasercrmck, NickHung. - Use MCBasedABI - Remove ArchSpec core bits, to be moved to D86292 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

labath added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.h:9 + +#ifndef liblldb_ABISysV_riscv_h_ +#define liblldb_ABISysV_riscv_h_ We use a different format for header guards these days. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

labath added a comment. Two months isn't that long, actually. Let's first see if there's anything else in this patch that we *can* test. It seems like we should be able to test the remainder of the ObjectFileELF changes if we extended lldb-test to dump the architecture flags too. Can you try s

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

labath added a comment. ABI plugins are one of the hardest things to test in lldb, particularly without actual hardware. That's why we've let them be added in the past without any accompanying tests. The situation is not ideal though, because we've accumulated various ABI plugins which are hard

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

wallace added a comment. @luismarques , what's the recommended gdb-server implementation you recommend for me to try this on a riscv machine? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 ___

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2288013 , @JDevlieghere wrote: > Sounds reasonable to me. Maybe it's still to early for that but have you > tried running (part of) the test suite under QEMU yet? It should give you a > pretty good idea of the stat

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

JDevlieghere added a comment. In D62732#2254440 , @luismarques wrote: > @labath @jrtc27 @clayborg Now that we have at least 3 open-source debug > servers that we can use to test this with (OpenOCD, QEMU gdbstub, gdbserver) > perhaps this can be merged? I

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2286332 , @wallace wrote: > @luismarques , what's the recommended gdb-server implementation you recommend > for me to try this on a riscv machine? I compiled mine from the mainline binutils-gdb git repository (runni

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques commandeered this revision. luismarques added a reviewer: simoncook. luismarques added a comment. Commandeering the patch, as discussed in the last RISC-V sync-up call. I'll update it with only minor changes; further development can be done in follow-up patches. Repository: rG LL

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. @labath @jrtc27 @clayborg Now that we have at least 3 open-source debug servers that we can use to test this with (OpenOCD, QEMU gdbstub, gdbserver) perhaps this can be merged? I had very good results using this patch with OpenOCD. This patch doesn't include automat

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques updated this revision to Diff 289696. luismarques added a comment. - Fix list of callee saved registers; - Fix typo; - Fix trivial clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

simoncook updated this revision to Diff 286749. simoncook added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/source/Plugins/ABI/CMak

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2193729 , @simoncook wrote: > As for next steps, if we're happy with the state then I think this should > land (assuming qemu is sufficient given it is public), and then we can flesh > out other bits which give a be

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

simoncook added a comment. Herald added a subscriber: JDevlieghere. Thanks for looking at this @luismarques We had planned to put more effort into this patch, but time got in the way for quite a lot, but I'm glad it's working; thanks for the rebase I'll update this to match shortly. And it's goo

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2038309 , @jrtc27 wrote: > Yeah, I don't think we want to be merging code we can't test even in a > non-automated way. Even if this code is completely bug-free, the inability to > test it just means we risk having i

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jrtc27 added a comment. Yeah, I don't think we want to be merging code we can't test even in a non-automated way. Even if this code is completely bug-free, the inability to test it just means we risk having it bit-rot with nobody noticing. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

labath added a comment. So, if I understand correctly, this patch doesn't just add an "ABI" plugin (for which we have in the past agreed that we don't know of a better way to test than just running "TestReturnValue" on the given architecture), but it actually adds all the bits and pieces neces

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

simoncook updated this revision to Diff 225998. simoncook retitled this revision from "[WIP][RISCV] Initial port of LLDB for RISC-V" to "[RISCV] Add SystemV ABI". simoncook edited the summary of this revision. simoncook added a comment. Herald added subscribers: pzheng, s.egerton, lenary, arichard