Re: [Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

On Tue, Jun 4, 2019 at 4:15 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > In D62634#1527575 , @dblaikie > wrote: > > > > 1. We need to figure out whether there's a bug in clang and fix it. + > @dblaikie for

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

labath added a comment. In D62634#1527575 , @dblaikie wrote: > > 1. We need to figure out whether there's a bug in clang and fix it. + > > @dblaikie for help with that > > This is intentional behavior in clang (controllable under the > -f[no-]split-dwarf

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

dblaikie added a comment. In D62634#1527634 , @probinson wrote: > In D62634#1527575 , @dblaikie wrote: > > > This is intentional behavior in clang (controllable under the > > -f[no-]split-dwarf-inlining flag, and m

Re: [Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

> On Jun 3, 2019, at 8:33 AM, Pavel Labath via Phabricator > wrote: > > labath added a subscriber: dblaikie. > labath added a comment. > > Actually, there was a subtle change of behavior here. Before this change, if > we tried to parse a DIE using an abbreviation table from a different file,

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

probinson added a comment. In D62634#1527575 , @dblaikie wrote: > This is intentional behavior in clang (controllable under the > -f[no-]split-dwarf-inlining flag, and modified by the > -f[no-]debug-info-for-profiling flag). > > This extra debug info is

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

dblaikie added a comment. In D62634#1527533 , @labath wrote: > Actually, there was a subtle change of behavior here. Before this change, if > we tried to parse a DIE using an abbreviation table from a different file, we > would most likely fail immediate

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

labath added a subscriber: dblaikie. labath added a comment. Actually, there was a subtle change of behavior here. Before this change, if we tried to parse a DIE using an abbreviation table from a different file, we would most likely fail immediately because of the fail-safe in GetAbbreviationD

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

clayborg added a comment. In D62634#1526174 , @jankratochvil wrote: > On Fedora 29 x86_64 it broke: > > FAIL: LLDB > (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-9-x86_64) :: > test_enable_dwo (TestBreakpointLocations.BreakpointLocations

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

jankratochvil added a comment. On Fedora 29 x86_64 it broke: FAIL: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-9-x86_64) :: test_enable_dwo (TestBreakpointLocations.BreakpointLocationsTestCase) FAIL: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-9-x86_

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

clayborg closed this revision. clayborg added a comment. r362103 | gclayton | 2019-05-30 08:21:23 -0700 (Thu, 30 May 2019) | 9 lines Improve DWARF parsing and accessing by 1% to 2% When LLDB first started we didn't have our mmap of the DWARF data done correctly and if the backing file would cha

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

clayborg added a comment. In D62634#1522249 , @aprantl wrote: > Out of curiosity, what was that change in the mmap call that fixed this? We switched to mapping things private and shared. This might be been before open sourcing happened so there might no

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

clayborg added a comment. In D62634#1522631 , @labath wrote: > BTW, how do you measure these things? > > When I tried to benchmark something I got a difference of at least 5% on what > should be identical runs. I'd have to make hundreds of runs in order f

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

labath added a comment. BTW, how do you measure these things? When I tried to benchmark something I got a difference of at least 5% on what should be identical runs. I'd have to make hundreds of runs in order for a 1% difference in average to show up as statistically significant.. CHANGES SIN

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

labath accepted this revision. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:724 uint32_t curr_depth) const { - const DWARFAbbreviationDeclaration *abbrevDecl = nullptr; - lldb::offset_t offset = 0; - if (cu) -abbrev

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

JDevlieghere accepted this revision. JDevlieghere added a comment. Great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62634/new/ https://reviews.llvm.org/D62634 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Out of curiosity, what was that change in the mmap call that fixed this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62634/new/ https://reviews.llvm.org/D62634

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, aprantl. When LLDB first started we didn't have our mmap of the DWARF data done correctly and if the backing file would change we would get live changes as the file changed and it would cause problems. We now mmap co