Re: [Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

2019-06-05 Thread Pavel Labath via lldb-commits
The "overlapping sections" thread reminding me I should reply here.. It also reminded me of another possible use case for multiply-mapped sections. Thread-local sections (.tbss, .tdata in elf) contain data which is somehow (the exact mechanisms are still quite opaque to me) mapped memory for ea

Re: [Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

2019-05-30 Thread Jim Ingham via lldb-commits
> On May 28, 2019, at 7:59 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > In D62505#1519166 , @aadsm wrote: > >> Interesting, I did miss that comment when I checked that class. This is >> something @clayborg was concerned w

[Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

2019-05-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D62505#1519166 , @aadsm wrote: > Interesting, I did miss that comment when I checked that class. This is > something @clayborg was concerned with when I discussed this solution with > him. The main reason I was not keen in havi

[Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

2019-05-28 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D62505#1518833 , @labath wrote: > I agree we need to support a module being loaded multiple times, but I'm not > sure if this is the right way to achieve that. I mean, if two files are > exactly the same, then it should be fi

[Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

2019-05-28 Thread António Afonso via Phabricator via lldb-commits
aadsm added a comment. Interesting, I did miss that comment when I checked that class. This is something @clayborg was concerned with when I discussed this solution with him. The main reason I was not keen in having multiple load addresses for a section is because that would change the GetLoadA

[Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

2019-05-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: jingham. labath added a subscriber: jingham. labath added a comment. I agree we need to support a module being loaded multiple times, but I'm not sure if this is the right way to achieve that. I mean, if two files are exactly the same, then it should be fine (and even pr

[Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

2019-05-27 Thread António Afonso via Phabricator via lldb-commits
aadsm created this revision. aadsm added reviewers: clayborg, xiaobai, labath. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. This solves the problem of lldb not recognizing android vendor's ndks that can live along side the system ndks. More about this feature her