This revision was automatically updated to reflect the committed changes.
Closed by commit rL361675: Cleanup fixed form sizes. (authored by gclayton,
committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D62416?v
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Looks like a good change. Small comment inline but otherwise LGTM.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3170
uint32_t
clayborg updated this revision to Diff 201302.
clayborg added a comment.
Removed unused function added to DWARFFormValue
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62416/new/
https://reviews.llvm.org/D62416
Files:
source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.cpp
source/Plugins/S
clayborg created this revision.
clayborg added reviewers: labath, aprantl, JDevlieghere.
Herald added a subscriber: arphaman.
The fix form sizes use to have two arrays: one for 4 byte addresses and in for
8 byte addresses. The table had an issue where DW_FORM_flag_present wasn't
being represente