[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. Do you need some help fixing the build? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.llvm.org/D62213 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

labath added a comment. You might want to have a look at https://reviews.llvm.org/D65409 which might fix (some of?) the issues mentioned here. I don't know if this is relevant or not, but I thought I'd say that on linux we also effectively aren't able to debug a 64-bit process with a 32-bit l

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. I can confirm this is reproducible with the master branch of llvm-project cloned from GitHub. You can reproduce the build failure from an x64 command prompt with this cmake command line: cmake path-to-llvm-project/llvm -Thost=x64 -DLLVM_ENABLE_PROJECTS="clang;lld;lld

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

xiaobai added a comment. In D62213#1605521 , @asmith wrote: > I think this change has introduced a dependence on x64. > > I tried building with the 32b Visual Studio compiler and there are a number > of undefined registers in registercontextwindows_x64.cp

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. I think this change has introduced a dependence on x64. I tried building with the 32b Visual Studio compiler and there are a number of undefined registers in registercontextwindows_x64.cpp. This is because the version of _CONTEXT included by winnt.h is for x32 and not x6

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

mgorny added inline comments. Comment at: lldb/trunk/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:231 + case llvm::Triple::OSType::Solaris: + case llvm::Triple::OSType::UnknownOS: +return ABISP(new ABISysV_x86_64(process_sp)); There's NetBS

Re: [Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

Hi Alex, It seems that the two variables in file ABIWindows_x86_64.cpp are unused: Line 1656: field_bit_width Line 1666: field_byte_flags On Mon, Jun 24, 2019 at 11:23 AM Alex Langford via Phabricator via lldb-commits wrote: > This revision was automatically updated to reflect the committed ch

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rL364216: [ABI] Implement Windows ABI for x86_64 (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 205640. kusmour added a comment. allow SysV_x86_64 ABI to handle unknown OS type this should fix the test `SymbolFile/DWARF/debug_loc.s` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.llvm.org/D622

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

labath added a comment. In D62213#1549190 , @kusmour wrote: > > Maybe we should make the SysV abi plugin match unknown oss too... > > I'm not sure this is the right thing to do, but this should fix the problem. It would at least preserve status quo. Not

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour added a comment. @labath Hi, you're right about the `lld`, it didn't make the test pass, instead it became unsupported. In D62213#1548835 , @labath wrote: > Can you elaborate on that? How exactly did it break this test? So the problem here is t

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

labath added a comment. In D62213#1548788 , @kusmour wrote: > the OS check in SysV x64 ABI broke the test `SymbolFile/DWARF/debug_loc.s` Can you elaborate on that? How exactly did it break this test? > added a restriction `lld` to `#REQUIRES` That defi

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 205390. kusmour added a comment. the OS check in SysV x64 ABI broke the test `SymbolFile/DWARF/debug_loc.s` added a restriction `lld` to `#REQUIRES` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.l

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 204885. kusmour added a comment. complete the code for floating point registers and cleaned up the support for floating point registers fixed `TestRegistersIterator` update the testcased Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 204695. kusmour added a comment. Added support for XMM registers. Now the step out on a function returns floating point number should have the right value. To play with it, define a function float getFloat(float value) { return value; } set a brea

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 203061. kusmour added a comment. Update the `GetReturnValueObjectImpl` using function `CanPassInRegisters` to explicitly check NOTE: There's NO register context info about registers beyond general purpose registers So floating point return type is not suppo

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 201377. kusmour added a comment. update the `CreateDefaultUnwindPlan`. return false or give empty Unwind Plan may cause lldb to crash and break tests on windows. So for now, copy the SysV-x86_64 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 200844. kusmour added a comment. update nit Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.llvm.org/D62213 Files: lldb/source/API/SystemInitializerFull.cpp lldb/source/Plugins/ABI/CMakeLists.t

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour marked an inline comment as done. kusmour added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1096 + if (arch_type == llvm::Triple::x86_64 +&& os_type == llvm::Triple::OSType::Win32) { +return ABISP(new ABIWindows_x86_6

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:1094 + if (arch_type == llvm::Triple::x86_64 && + os_type != llvm::Triple::OSType::Win32) {

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.h:63 + return false; // Zero is not a valid stack address +return true; + } kusmour wrote: > compnerd wrote: > > Can we add an additional test pleas

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour marked 16 inline comments as done. kusmour added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1257-1259 + +// We currently only support extracting values with Clang QualTypes. Do we +// care about others? -

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 200622. kusmour added a comment. Herald added a subscriber: fedor.sergeev. update a new version based on comment. cleaned some useless comment change to use CHAR_BIT for readability Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

xiaobai added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1257-1259 + +// We currently only support extracting values with Clang QualTypes. Do we +// care about others? I don't see any references to clang in

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

compnerd added inline comments. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:1094 + if (arch_type == llvm::Triple::x86_64 && + os_type != llvm::Triple::OSType::Win32) { return ABISP(new ABISysV_x86_64(process_sp)); This really isn

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour created this revision. kusmour added reviewers: xiaobai, compnerd. kusmour added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, mgorny. Implement the ABI for WIndows-x86_64 including register info and calling convention. Handled nested struct returned in register (Sys