[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

2019-05-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361046: [Docs] Remove SVN checkout from LLDB build steps (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

2019-05-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62041/new/ https://reviews.llvm.org/D62041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

2019-05-17 Thread J. Ryan Stinnett via Phabricator via lldb-commits
jryans marked 2 inline comments as done. jryans added a comment. Thanks for the review @JDevlieghere! 😄 This should be ready for another look. I don't have commit access yet, so assuming it's approved, please commit when you have time. Comment at: lldb/docs/resources/build.rs

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

2019-05-17 Thread J. Ryan Stinnett via Phabricator via lldb-commits
jryans updated this revision to Diff 13. jryans added a comment. Updated to remove the whole section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62041/new/ https://reviews.llvm.org/D62041 Files: lldb/docs/resources/build.rst Index: lldb/

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

2019-05-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/docs/resources/build.rst:242 -We first need to checkout the source trees into the appropriate locations. Both -Clang and LLDB build as subprojects of LLVM. This means we will be checking out -the source for both Clang and LLD

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

2019-05-16 Thread J. Ryan Stinnett via Phabricator via lldb-commits
jryans created this revision. jryans added a reviewer: JDevlieghere. Herald added a project: LLDB. This removes several older paragraphs in the LLDB build steps for Unix systems which suggested checking out various components via SVN. Since there's a separate page about getting the LLDB source whi