This revision was automatically updated to reflect the committed changes.
aganea marked an inline comment as done.
Closed by commit rL361295: Fix LLDB warnings when compiling with Clang 8.0
(authored by aganea, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
aganea marked 2 inline comments as done.
aganea added inline comments.
Comment at: source/Host/windows/ProcessLauncherWindows.cpp:35-37
+ reinterpret_cast(const_cast(warg.c_str())),
+ reinterpret_cast(
+ const_cast(warg.c_str() + warg.size() + 1)));
labath added inline comments.
Comment at: source/Host/windows/ProcessLauncherWindows.cpp:35-37
+ reinterpret_cast(const_cast(warg.c_str())),
+ reinterpret_cast(
+ const_cast(warg.c_str() + warg.size() + 1)));
I don't believe the con
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62021/new/
https://reviews.llvm.org/D62021
___
aganea created this revision.
aganea added reviewers: JDevlieghere, aleksandr.urakov, asmith, mgorny.
aganea added a project: LLDB.
Herald added subscribers: lldb-commits, abidh, aprantl.
Ditto. Please see warnings list:
[2660/3259] Building CXX object
tools\lldb\source\Host\CMakeFiles\lldbHos
