davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61872/new/
https://reviews.llvm.org/D61872
___
lldb-commits mailing list
lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB360621: [CMake] Simplify lldb-server handling (authored
by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61872?vs=199327&id=199328#toc
Repository:
rLLDB LLDB
CH
davide added inline comments.
Comment at: lldb/tools/CMakeLists.txt:12
add_lldb_tool_subdirectory(lldb-mi)
+add_lldb_tool_subdirectory(lldb-server)
add_lldb_tool_subdirectory(lldb-vscode)
This probably predates the use of `add_lldb_tool_subdirectory` in lldb.
JDevlieghere updated this revision to Diff 199327.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61872/new/
https://reviews.llvm.org/D61872
Files:
lldb/cmake/modules/LLDBConfig.cmake
lldb/tools/CMakeLists.txt
lldb/unittests/tools/CMakeLists.txt
Index: lldb/unittests/tools/CMakeLi
JDevlieghere created this revision.
JDevlieghere added reviewers: sgraenitz, labath, davide.
Herald added subscribers: mgorny, srhines.
Herald added a project: LLDB.
We can piggyback off the existing add_lldb_tool_subdirectory to decide whether
or not lldb-server should be built.
Repository:
