[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360409: FuncUnwinders: Add a new "SymbolFile" unwind plan (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

labath added a comment. In D61732#1497609 , @jasonmolenda wrote: > I'm not super concerned about the size of the UnwindPlan or FuncUnwinders > objects - we create them lazily as we unwind through functions in the > process, so my guess is that even a lo

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good to me. Yes, we need to change from a model of "the remote stub teaches lldb everything about registers" to "lldb knows all the architectural / ABI register number detai

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

labath added a comment. In D61732#1496575 , @clayborg wrote: > Looks good except the inline comment about all the unwind plans we have now. > Would love to simplify this so that EH frame, compact unwind, ARM unwind, > breakpad unwind all come from the sy

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

clayborg added a comment. Looks good except the inline comment about all the unwind plans we have now. Would love to simplify this so that EH frame, compact unwind, ARM unwind, breakpad unwind all come from the symbol file or object files. Also be nice to have a register resolver that works wit

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

labath created this revision. labath added reviewers: jasonmolenda, clayborg. some unwind formats are specific to a single symbol file and so it does not make sense for their parsing code live in the general Symbol library (as is the case with eh_frame for instance). This is the case for the unwin