[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

asmith updated this revision to Diff 214979. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61686/new/ https://reviews.llvm.org/D61686 Files: cmake/modules/LLDBConfig.cmake source/Host/windows/Host.cpp source/Plugins/Process/gdb-remote/GDB

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: cmake/modules/LLDBConfig.cmake:421 # ensure we build lldb-server when an lldb target is being built. -if (CMAKE_SYSTEM_NAME MATCHES "Android|Darwin|FreeBSD|L

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

JDevlieghere added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:421 # ensure we build lldb-server when an lldb target is being built. -if (CMAKE_SYSTEM_NAME MATCHES "Android|Darwin|FreeBSD|Linux|NetBSD") +if (CMAKE_SYSTEM_NAME MATCHES "Android|Darwin|FreeBSD|Linux

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

asmith updated this revision to Diff 199555. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61686/new/ https://reviews.llvm.org/D61686 Files: cmake/modules/LLDBConfig.cmake source/Host/windows/Host.cpp source/Plugins/Process/gdb-remote/GDB

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

compnerd added inline comments. Comment at: include/lldb/Host/windows/PosixApi.h:106-109 +inline pid_t waitpid(pid_t pid, int *status, int options) { + // To be implemented. + return pid_t(-1); +} labath wrote: > As discussed in the review where this was forked

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

labath added inline comments. Comment at: include/lldb/Host/windows/PosixApi.h:106-109 +inline pid_t waitpid(pid_t pid, int *status, int options) { + // To be implemented. + return pid_t(-1); +} As discussed in the review where this was forked from, we shouldn'

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

compnerd added inline comments. Comment at: include/lldb/Host/windows/PosixApi.h:108 + // To be implemented. + return pid_t(-1); +} This should be out-of-lined. Furthermore, is there any place where the use requires process group handling? Otherwise, can't w

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

amccarth marked an inline comment as done. amccarth added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:220 +// In most cases the missing notifications do not affect lldb-server +// so we are temporarily relaxing the

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

Hui added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:220 +// In most cases the missing notifications do not affect lldb-server +// so we are temporarily relaxing the following for Windows. +#if !defined(_WIN32) ---

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

amccarth added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:220 +// In most cases the missing notifications do not affect lldb-server +// so we are temporarily relaxing the following for Windows. +#if !defined(_WIN32

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

asmith updated this revision to Diff 198675. asmith retitled this revision from "Disable pty redirection on Windows and add a method to get the parent pid" to "Enable lldb-server on Windows". asmith edited the summary of this revision. Herald added subscribers: mgorny, srhines. CHANGES SINCE LAST