[Lldb-commits] [PATCH] D61548: Fix use of 'is' operator for comparison

2020-04-06 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. I rewrote this test in acb0b99c8e4f1dc65a7f1e26da9db77239a67da7 so this isn't necessary anymore. Thanks for the patch though! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D61548: Fix use of 'is' operator for comparison

2020-04-03 Thread Raul Tambre via Phabricator via lldb-commits
tambre added a comment. In D61548#1960310 , @JDevlieghere wrote: > Why did you abandon this? It's been lingering for a long time, so I wanted to get it off my dashboard. The patch also requires updating as the file has moved. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D61548: Fix use of 'is' operator for comparison

2020-04-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Why did you abandon this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61548/new/ https://reviews.llvm.org/D61548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D61548: Fix use of 'is' operator for comparison

2019-05-04 Thread Raul Tambre via Phabricator via lldb-commits
tambre created this revision. tambre added a reviewer: zturner. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The 'is' operator is not meant to be used for comparisons. It currently working is an implementation detail of CPython. CPython 3.8 has added a SyntaxWarning for