[Lldb-commits] [PATCH] D61502: Permit cross-CU references

This revision was automatically updated to reflect the committed changes. Closed by commit rL360795: Permit cross-CU references (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D61502: Permit cross-CU references

jankratochvil marked an inline comment as done. jankratochvil added a comment. In D61502#1503247 , @clayborg wrote: > Just a few simplifications to GetName() and AppendTypeName() are in question > and can optionally be done if needed. I will do that in

[Lldb-commits] [PATCH] D61502: Permit cross-CU references

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just a few simplifications to GetName() and AppendTypeName() are in question and can optionally be done if needed. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARF

[Lldb-commits] [PATCH] D61502: Permit cross-CU references

labath added a comment. I like this patch in a lot of ways, because it makes the code cleaner, and prepares us for DWARF5, which can reference entries in other files in a lot of interesting ways. The part I am not totally sure if is the alignment of lldb's DWARFFormValue with it's llvm counter

[Lldb-commits] [PATCH] D61502: Permit cross-CU references

jankratochvil updated this revision to Diff 199490. jankratochvil retitled this revision from "03/06: New CUDIERef" to "Permit cross-CU references". jankratochvil edited the summary of this revision. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61502/new/ https