[Lldb-commits] [PATCH] D61482: [DWARF] Store compile unit IDs in the DIERef class

labath abandoned this revision. labath added a comment. Obsoleted by D61908 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61482/new/ https://reviews.llvm.org/D61482 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D61482: [DWARF] Store compile unit IDs in the DIERef class

labath planned changes to this revision. labath added a comment. My understanding of the DIERef class has evolved. I'm going to revise this approach a bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61482/new/ https://reviews.llvm.org/D61482 __

[Lldb-commits] [PATCH] D61482: [DWARF] Store compile unit IDs in the DIERef class

labath added a comment. Hm... looking at @jankratochvil's patches, I realized that I completely omitted HashedNameToDIE from this patch (it used `emplace_back` to construct DIERefs, so it snuck past me). Thinking about it, I guess the best way to handle that would be to set the cu_idx to the in

[Lldb-commits] [PATCH] D61482: [DWARF] Store compile unit IDs in the DIERef class

labath updated this revision to Diff 197936. labath added a comment. Fix two more things I noticed when looking at the patch in phab: - incorrect use of unit offset in DIERef constructor in the DebugMap case (I'm guessing this didn't cause any test failures because both offsets and IDs are gene

[Lldb-commits] [PATCH] D61482: [DWARF] Store compile unit IDs in the DIERef class

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added a subscriber: arphaman. The offset of a compile unit is enough to identify in a section, but things start to get a lot more complicated when you have multiple object files, each with potentially sev