This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL360350: MinidumpYAML: add support for the ThreadList stream
(authored by labath, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61423?vs=1986
labath marked 6 inline comments as done.
labath added a comment.
Thanks for the review.
Comment at: test/tools/obj2yaml/basic-minidump.yaml:47-49
+ - Thread Id: 0x5C5D5E5F
+Priority Class: 0x60616263
+Environment Block: 0x6465666768696A6B
---
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with the suggested fixes.
Comment at: test/tools/obj2yaml/basic-minidump.yaml:47-49
+ - Thread Id: 0x5C5D5E5F
+Priority Class: 0x60616263
+
labath updated this revision to Diff 198653.
labath marked 2 inline comments as done.
labath added a comment.
Address review comments.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61423/new/
https://reviews.llvm.org/D61423
Files:
include/llvm/ObjectYAML/Minidu
labath marked 9 inline comments as done.
labath added inline comments.
Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:58
+/// streams with similar structure.
+template
+struct ListStream : public Stream {
jhenderson wrote:
> KindV and TypeV aren't clear name
jhenderson added inline comments.
Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:57
+/// instantiations can be used to represent the ModuleList stream and other
+/// streams with similar structure.
+template
with -> with a
Comment at: incl
clayborg added a comment.
lgtm
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61423/new/
https://reviews.llvm.org/D61423
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
labath created this revision.
labath added reviewers: amccarth, jhenderson, clayborg.
Herald added a project: LLVM.
The implementation is a pretty straightforward extension of the pattern
used for (de)serializing the ModuleList stream. Since there are other
streams which use the same format (Memor
