compnerd closed this revision.
compnerd added a comment.
SVN r359810
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61360/new/
https://reviews.llvm.org/D61360
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
Comment at: source/API/SystemInitializerFull.cpp:132-133
+ ObjectContainerBSDArchive::Initialize();
+ ObjectContainerUniversalMachO::Initialize();
+
compnerd added inline comments.
Comment at: source/API/SystemInitializerFull.cpp:132-133
+ ObjectContainerBSDArchive::Initialize();
+ ObjectContainerUniversalMachO::Initialize();
+
labath wrote:
> xiaobai wrote:
> > You need to include the headers for these c
compnerd updated this revision to Diff 197797.
compnerd marked 6 inline comments as done.
compnerd added a comment.
address feedback
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61360/new/
https://reviews.llvm.org/D61360
Files:
source/API/SystemInitializerF
labath added inline comments.
Comment at: source/API/CMakeLists.txt:99-100
lldbUtility
+lldbPluginObjectContainerBSDArchive
+lldbPluginObjectContainerMachOArchive
${LLDB_ALL_PLUGINS}
xiaobai wrote:
> These should get sucked into LLDB_ALL_PLUGINS
xiaobai added inline comments.
Comment at: source/API/SystemInitializerFull.cpp:132-133
+ ObjectContainerBSDArchive::Initialize();
+ ObjectContainerUniversalMachO::Initialize();
+
You need to include the headers for these classes
Repository:
rLLDB LLDB
C
xiaobai added inline comments.
Comment at: source/API/CMakeLists.txt:99-100
lldbUtility
+lldbPluginObjectContainerBSDArchive
+lldbPluginObjectContainerMachOArchive
${LLDB_ALL_PLUGINS}
These should get sucked into LLDB_ALL_PLUGINS right?
Reposi
compnerd created this revision.
compnerd added reviewers: davide, aprantl, clayborg.
Herald added subscribers: abidh, mgorny.
Herald added a project: LLDB.
This restructures the initialization path to move the ObjectContainer
initialization into the *full* initialization path. This is not needed
