[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

labath added a comment. In D61244#1482196 , @teemperor wrote: > In D61244#1482146 , @labath wrote: > > > LG, but note that this has no effect on the overall set of tests which will > > run as long as gmodules remai

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

teemperor added a reviewer: aprantl. teemperor planned changes to this revision. teemperor added a comment. I looked into this a bit further and I think the best way forward is to enable gmodules on Linux but exclude all tests that rely on system modules (i.e. std or libc) as that really seems t

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

teemperor added a comment. In D61244#1482146 , @labath wrote: > LG, but note that this has no effect on the overall set of tests which will > run as long as gmodules remains disabled in > `test_categories.is_supported_on_platform`. Oh, true, thanks for

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

teemperor updated this revision to Diff 197074. teemperor added a comment. - Add 'linux' to the list of platforms supporting gmodules. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61244/new/ https://reviews.llvm.org/D61244 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/gmodule

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

labath added a comment. LG, but note that this has no effect on the overall set of tests which will run as long as gmodules remains disabled in `test_categories.is_supported_on_platform`. The other thing to note is that the effect of enabling gmodules extremely strongly depends on how your sys

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61244/new/ https://reviews.llvm.org/D61244 ___ lldb-commits

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

teemperor created this revision. teemperor added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. teemperor edited the summary of this revision. These tests are not failing for me on (Arch) Linux, so I would suggest that we re-enable them. See also http:/