[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

kwk marked an inline comment as done. kwk added inline comments. Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737 TagTypeNode *Demangler::parseTagUniqueName(StringView &MangledName) { + if (!MangledName.consumeFront(".?A")) { thakis wrote: > kwk wrote:

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

thakis added inline comments. Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737 TagTypeNode *Demangler::parseTagUniqueName(StringView &MangledName) { + if (!MangledName.consumeFront(".?A")) { kwk wrote: > Why not change the return type to `llvm::Expecte

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

kwk added inline comments. Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737 TagTypeNode *Demangler::parseTagUniqueName(StringView &MangledName) { + if (!MangledName.consumeFront(".?A")) { Why not change the return type to `llvm::Expected`? Then you hav

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

thakis added a comment. Add a test that fails without the code change and that passes with it. I don't know under which conditions this change is needed, so I apologize that I can't make a more concrete suggestion. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

zloyrobot added a comment. kind reminder Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60963/new/ https://reviews.llvm.org/D60963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

zloyrobot added a comment. In D60963#1474783 , @thakis wrote: > test? Would you please advise me on what kind of test I should add for such fix? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60963/new/ https://reviews

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

thakis added a comment. test? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60963/new/ https://reviews.llvm.org/D60963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

zloyrobot created this revision. zloyrobot added reviewers: amccarth, thakis. zloyrobot added a project: LLDB. Herald added subscribers: llvm-commits, lldb-commits, erik.pilkington, hiraditya. Herald added a project: LLVM. All callers of Demangler::parseTagUniqueName check 'Demangler.Error' and a