[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

asmith added a comment. Herald added a subscriber: JDevlieghere. Curious what the status of this is? Looks like its been ready for almost one year :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 __

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot added a comment. In D60962#1504921 , @labath wrote: > Adrian is on vacation now, but given that he was just waiting until you > resolve my comments (which you have), I think we don't have to wait for him. Thank you for one more review. Repos

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

labath accepted this revision. labath added a comment. Adrian is on vacation now, but given that he was just waiting until you resolve my comments (which you have), I think we don't have to wait for him. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot added a comment. In D60962#1477160 , @amccarth wrote: > Thanks Pavel! > > Please address Pavel's inline comments, and I'll accept this. Kind reminder Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot marked 2 inline comments as done. zloyrobot added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:110 + +static std::string findPdbFile(const llvm::StringRef exe_path, const llvm::StringRef pdb_file, llvm::file_magic &magic

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot updated this revision to Diff 196614. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 Files: lldb/lit/SymbolFile/NativePDB/Inputs/pdb-file-lookup.lldbinit lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

labath added a subscriber: zturner. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:110 + +static std::string findPdbFile(const llvm::StringRef exe_path, const llvm::StringRef pdb_file, llvm::file_magic &magic) { + auto

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot marked 2 inline comments as done. zloyrobot added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:110 + +static std::string findPdbFile(const llvm::StringRef exe_path, const llvm::StringRef pdb_file, llvm::file_magic &magic

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

amccarth added a comment. Thanks Pavel! Please address Pavel's inline comments, and I'll accept this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 ___ lldb-commits maili

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

labath added a comment. The problem I have is that PDB is not following the lldb convention of doing the symbol file search inside a SymbolVendor class (which should really be called a SymbolFinder), but instead they implement their own little symbol vendor privately. There are reasons which ma

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

amccarth added a comment. cc: Pavel Labath because I know he's been involved in conversations about how to find symbol files in general (PDB, split DWARF, Breakpad, etc.), especially when doing post-mortem debugging. I believe there are complications when the debugger host is different than the

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot updated this revision to Diff 196232. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 Files: lldb/lit/SymbolFile/NativePDB/Inputs/pdb-file-lookup.lldbinit lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot updated this revision to Diff 196226. zloyrobot added a comment. Add test case for searching .pdb file in the same folder as .exe file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 Files: lldb/lit/SymbolFile/NativePDB/pdb-file-look

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot added inline comments. Comment at: lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp:4 + +// Test that we can find .pdb file in folder containing .exe file. +// RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s stella.stamenova wrote: > Is

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

stella.stamenova added inline comments. Comment at: lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp:4 + +// Test that we can find .pdb file in folder containing .exe file. +// RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s Is this not testing f

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot created this revision. zloyrobot added reviewers: amccarth, asmith, stella.stamenova. zloyrobot added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. This patch adds ability to find .pdb files in NT_SYMBOL_PATH folders and in .exe file folder Repository: rLLDB LL