labath added inline comments.
Comment at: lib/ObjectYAML/MinidumpYAML.cpp:21
+/// methods, while the final minidump file is written by calling the writeTo
+/// method. The plan versions of allocation functions take a reference to the
+/// data which is to be written (and hence th
This revision was automatically updated to reflect the committed changes.
labath marked 4 inline comments as done.
Closed by commit rL358672: MinidumpYAML: Add support for ModuleList stream
(authored by labath, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D60405?vs=194130&i
jhenderson accepted this revision.
jhenderson added inline comments.
Comment at: lib/ObjectYAML/MinidumpYAML.cpp:21
+/// methods, while the final minidump file is written by calling the writeTo
+/// method. The plan versions of allocation functions take a reference to the
+/// da
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
Nice!
Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:57
+/// record. In memory, we represent these as the ParsedModule struct, which
+/// groups minidump::Module with
clayborg added inline comments.
Comment at: lib/ObjectYAML/MinidumpYAML.cpp:91
+
size_t BlobAllocator::allocateString(StringRef Str) {
SmallVector WStr;
labath wrote:
> clayborg wrote:
> > Might be nice to unique the strings in here?
> Yeah, that would be pos
labath marked an inline comment as done.
labath added inline comments.
Comment at: lib/ObjectYAML/MinidumpYAML.cpp:91
+
size_t BlobAllocator::allocateString(StringRef Str) {
SmallVector WStr;
clayborg wrote:
> Might be nice to unique the strings in here?
Yeah
clayborg added a comment.
LGTM. Probably should get one more ok
Comment at: lib/ObjectYAML/MinidumpYAML.cpp:91
+
size_t BlobAllocator::allocateString(StringRef Str) {
SmallVector WStr;
Might be nice to unique the strings in here?
Repository:
rL LLVM
CH
labath created this revision.
labath added reviewers: amccarth, jhenderson, clayborg, zturner.
Herald added a project: LLVM.
This patch adds support for yaml (de)serialization of the minidump
ModuleList stream. It's a fairly straight forward-application of the
existing patterns to the ModuleList s
