[Lldb-commits] [PATCH] D60254: Add dropped ManualDWARFIndex assert()

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357678: Add dropped ManualDWARFIndex assert() (authored by jankratochvil, committed by ). Changed prior to commit: h

[Lldb-commits] [PATCH] D60254: Add dropped ManualDWARFIndex assert()

jankratochvil added a comment. Maybe I will have to update `GetBaseCompileUnit`, maybe not. But as I find the assert useful (for `-fdebug-types-section -gsplit-dwarf`) going to add back the assertion. Thanks for the reply. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D60254: Add dropped ManualDWARFIndex assert()

labath added a comment. I don't exactly remember my thought processes there, but I guess I have dropped that assert during the refactor because it was obvious to me. Now that you mention it, I don't have any particular opinion on what we should do. If it makes your job any easier, then go ahead

[Lldb-commits] [PATCH] D60254: Add dropped ManualDWARFIndex assert()

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added subscribers: arphaman, aprantl. D47253 dropped this assertion. So either add it back by this patch or otherwise I will remove currently