[Lldb-commits] [PATCH] D59968: [Cmake] Unify python variables

2019-03-29 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357282: [Cmake] Unify python variables (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D59968?vs=192735&id=192858#toc Repository: rLLDB LLDB CHANGES S

[Lldb-commits] [PATCH] D59968: [Cmake] Unify python variables

2019-03-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:246-247 else() -find_package(PythonLibs REQUIRED) +include(FindPythonInterp) +include(FindPythonLibs) endif() Is there any difference between `include(FindPythonInterp

[Lldb-commits] [PATCH] D59968: [Cmake] Unify python variables

2019-03-28 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59968/new/ https://reviews.llvm.org/D59968

[Lldb-commits] [PATCH] D59968: [Cmake] Unify python variables

2019-03-28 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: zturner, stella.stamenova, labath, sgraenitz. Herald added subscribers: lldb-commits, abidh, mgorny. Herald added a project: LLDB. Both FindPythonInterp and FindPythonLibs do two things, they'll set some variables (PYTHON_LIBRARIES