[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

This revision was automatically updated to reflect the committed changes. Closed by commit rL357749: Minidump: Add support for reading/writing strings (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D59775?vs=193698&id=193842#toc Repository: rL LLVM CH

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59775/new/ https://reviews.llvm.org/D59775 ___ lldb-c

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

labath updated this revision to Diff 193698. labath marked an inline comment as done. labath added a comment. add the size-does-not-fit test case Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59775/new/ https://reviews.llvm.org/D59775 Files: include/llvm/Object

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

labath marked 3 inline comments as done. labath added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:70 minidump::SystemInfo Info; + std::string CSDVersion; jhenderson wrote: > Don't know about lifetime here, but could this be a `String

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

jhenderson added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:70 minidump::SystemInfo Info; + std::string CSDVersion; Don't know about lifetime here, but could this be a `StringRef`? Comment at: unittests/Object/Min

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

labath added a reviewer: amccarth. labath added a comment. In D59775#1442987 , @clayborg wrote: > Looks fine to me, but probably need a LLVM specific person for the final ok Maybe @zturner or @amccarth could be the LLVM person ? :) Repository: rL LLV

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

clayborg added a comment. Looks fine to me, but probably need a LLVM specific person for the final ok Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59775/new/ https://reviews.llvm.org/D59775 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

labath created this revision. labath added reviewers: jhenderson, zturner, clayborg. Herald added a project: LLVM. labath added a parent revision: D59634: Add minidump support to obj2yaml. Strings in minidump files are stored as a 32-bit length field, giving the length of the string in *bytes*, wh