[Lldb-commits] [PATCH] D59634: Add minidump support to obj2yaml

2019-04-02 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3cee663e71f6: Add minidump support to obj2yaml (authored by labath). Herald added a subscriber: hiraditya. Changed prior to commit: https://reviews.llvm.org/D59634?vs=191656&id=193254#toc Repository:

[Lldb-commits] [PATCH] D59634: Add minidump support to obj2yaml

2019-04-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D59634#1451182 , @jhenderson wrote: > Sorry, I've been a bit snowed under with other stuff recently. I don't claim > to be an expert on obj2yaml, but this LGTM. No worries. You still have the fastest average response time for

[Lldb-commits] [PATCH] D59634: Add minidump support to obj2yaml

2019-04-02 Thread James Henderson via Phabricator via lldb-commits
jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. In D59634#1449621 , @labath wrote: > James, do you have any thoughts on this? I think the minidump-specific > changes are all pretty straight-f

[Lldb-commits] [PATCH] D59634: Add minidump support to obj2yaml

2019-04-01 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. James, do you have any thoughts on this? I think the minidump-specific changes are all pretty straight-forward here, so the thing I'm most interested in is whether this is ok from a obj2yaml perspective. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D59634: Add minidump support to obj2yaml

2019-03-21 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: jhenderson, zturner, clayborg. Herald added a subscriber: mgorny. Herald added a project: LLVM. This patch adds the code needed to parse a minidump file into the MinidumpYAML model, and the necessary glue code so that obj2yaml can recognise the