serge-sans-paille added a comment.
@davide : is that ok if I add you to a few other python compat related reviews?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59580/new/
https://reviews.llvm.org/D59580
___
lldb-c
serge-sans-paille added a comment.
validates fine on my side with py3
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59580/new/
https://reviews.llvm.org/D59580
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
This looks good to me as long as it doesn't break check-lldb (and from I quick
look at the patch I doubt it does). Thanks for helping with this!
Repository:
rLLDB LLDB
CHANGES SINCE LAST A
serge-sans-paille added a comment.
I didn't run the `check-lldb` target though, I'm doing that right now.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59580/new/
https://reviews.llvm.org/D59580
___
lldb-commits ma
serge-sans-paille added a comment.
@davide I first applied 2to3 systematically, then manually edited the diff so
that it remains backward compatible with python2.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59580/new/
https://reviews.llvm.org/D59580
_
davide added a comment.
Thanks for your interest in the subject of Python! I converted everything I was
able to find looking at our test suite, it seems that we lack coverage for
these scripts.
Did you end up testing them with both py 2 and py 3 or just applied a tool on
them?
Repository:
r
