This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB355974: Remove DWARFDIECollection. (authored by zturner,
committed by ).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D59165?vs=189961&id=190325#toc
Repository:
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
LGTM. I think we should eventually get rid of all the stl-container-wrapper
classes. (Apart from the SB ones, or course.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59165/new/
htt
Yes, it’s not the case here but even it were, just because the Python
interface exposes this api doesn’t mean we have to use it internally.
Regardless, this particular class is completely private and has no analogue
in the SB API
On Fri, Mar 8, 2019 at 4:53 PM Adrian Prantl via Phabricator <
revi.
aprantl added a comment.
Whenever I see a GetFooAtIndex() method I expect this to be exposed via the
SBAPI, but I assume this isn't the case here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59165/new/
https://reviews.llvm.org/D59165
___
zturner created this revision.
zturner added reviewers: clayborg, aprantl.
Herald added subscribers: jdoerfert, mgorny.
This is a very thin wrapper over a std::vector and does
not seem to provide any real value over just using a container
directly.
https://reviews.llvm.org/D59165
Files:
