Re: [Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

Yeah given the evidence, maybe it's fine left as is. I worked around it locally so I am not blocked. Thanks! On Monday, March 11, 2019, Jonas Devlieghere wrote: > It's weird that this only occurs when building with Xcode, none of the > bots seem affected. Anyway, I'm updating the macros and veri

Re: [Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

It's weird that this only occurs when building with Xcode, none of the bots seem affected. Anyway, I'm updating the macros and verifying the build works locally when using Xcode. On Sun, Mar 10, 2019 at 3:25 PM Dave Lee via Phabricator < revi...@reviews.llvm.org> wrote: > kastiglione added a comm

[Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

kastiglione added a comment. I'm getting build failures that appear to be caused by this patch. I'm compiling on macOS with Xcode 10.1. The failures are uses of `LLDB_RECORD_DUMMY()`, passing a callback function pointer as one of the args. This results in errors like: ../../tools/lldb/includ

[Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

JDevlieghere added a comment. In D59101#1422129 , @clayborg wrote: > As long as we are still seeing all argument values, I check the first 10 or > so calls and it looked like this was the case, then I am good with this. Correct, the macros forward the a

[Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

clayborg added a comment. As long as we are still seeing all argument values, I check the first 10 or so calls and it looked like this was the case, then I am good with this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59101/new/ https://reviews.llvm.org/D59